Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set explicit directory and file permissions on native libraries #106505

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Set explicit directory and file permissions on native libraries #106505

merged 1 commit into from
Mar 19, 2024

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Mar 19, 2024

The distributions already have correct permissions set on native libraries copied to them. However, the build itself to extract the native libs relies on the upstream file permissions. This commit sets explicit permissions on the copy task which extracts native libraries.

@rjernst
Set explicit directory and file permissions on native libraries
baad1df 
The distributions already have correct permissions set on native
libraries copied to them. However, the build itself to extract the
native libs relies on the upstream file permissions. This commit sets
explicit permissions on the copy task which extracts native libraries.
@rjernst rjernst added the :Core/Infra/Core Core issues without another label label Mar 19, 2024
@rjernst rjernst requested a review from a team as a code owner March 19, 2024 19:03
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team v8.14.0 labels Mar 19, 2024
brianseeders
brianseeders approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@brianseeders brianseeders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, I had to delete this file (with the old permissions) once first though:

elasticsearch/libs/native/libraries/build/platform/darwin-x64/libzstd.dylib

@rjernst rjernst added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Mar 19, 2024
@elasticsearchmachine elasticsearchmachine merged commit 444866a into elastic:main Mar 19, 2024
14 checks passed
@rjernst rjernst deleted the native/explicit_libraries_perms branch March 19, 2024 19:52
This was referenced Mar 21, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianseeders brianseeders brianseeders approved these changes

Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Core/Infra/Core Core issues without another label >refactoring Team:Core/Infra Meta label for core/infra team v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjernst @elasticsearchmachine @brianseeders