Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assumption in TimeSeriesIT #106448

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Fix assumption in TimeSeriesIT #106448

merged 1 commit into from
Mar 19, 2024

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Mar 19, 2024

This should be an assumption instead of an assertion.

Closes #106444

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :StorageEngine/TSDB You know, for Metrics labels Mar 19, 2024
@dnhatn dnhatn marked this pull request as ready for review March 19, 2024 01:35
@dnhatn dnhatn requested a review from martijnvg March 19, 2024 01:35
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dnhatn dnhatn merged commit 8357d2b into elastic:main Mar 19, 2024
14 checks passed
@dnhatn dnhatn deleted the fix-test-empty branch March 19, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :StorageEngine/TSDB You know, for Metrics Team:StorageEngine >test Issues or PRs that are addressing/adding tests v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] TimeSeriesIT testEmpty failing
3 participants