Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest Lucene bugfix version 8.11.3 #106365

Merged
merged 8 commits into from
Mar 18, 2024
Merged

Update to latest Lucene bugfix version 8.11.3 #106365

merged 8 commits into from
Mar 18, 2024

Conversation

benwtrent
Copy link
Member

No description provided.

@benwtrent benwtrent added >bug :Search/Search Search-related issues that do not fall into other categories v7.17.19 labels Mar 14, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Mar 14, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine
Copy link
Collaborator

Hi @benwtrent, I've created a changelog YAML for you.

@benwtrent
Copy link
Member Author

Pinging @elastic/es-core-infra (Team:Core/Infra)

Could y'all make sure I did this right?

benwtrent
benwtrent commented Mar 14, 2024
View reviewed changes
server/src/main/java/org/elasticsearch/Version.java Outdated
Comment on lines 181 to 182
public static final Version CURRENT = V_7_17_19;
public static final Version V_7_17_20 = new Version(7_17_20_99, org.apache.lucene.util.Version.LUCENE_8_11_3);
public static final Version CURRENT = V_7_17_20;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting a bunch of failures in CI about my version stuff.

Should I keep V_7_17_19 and just change the Lucene version since its a bugfix version and fully compatible?

@elastic/es-core-infra

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, new versions are only introduced at build release time. Just update the 7.17.19 constant

@benwtrent
Copy link
Member Author

@iverase || @craigtaverner would y'all mind looking at the XTessellatorTests failure?

It seems that the lucene bugfix release of 8.11.3 fixes some of the things these classes were covering and they need to be adjusted.

@iverase
Copy link
Contributor

iverase commented Mar 14, 2024

I can take a look next week. We need to remove XTessellator and XtessellatorTests and replace XTessellator with lucene Tessellator.

@iverase
Copy link
Contributor

iverase commented Mar 14, 2024

The exception says it clearly:

Expected tessellator to fail due to bug-fix - if this tests fails now it means Lucene has released the bugfix and we should delete the XTessellator class and usages of that (XLatLonShape, XShape)

@benwtrent
Copy link
Member Author

@iverase ok, I removed XTessellator and changed references to use Lucene's Tessellator.

@iverase
Copy link
Contributor

iverase commented Mar 14, 2024 •
edited
Loading

XLatLonShape and friends should / can be removed as well. (and usages of that (XLatLonShape, XShape)).

@benwtrent
Copy link
Member Author

I removed XLatLonShape (FWIW, CI was green with just the XTessellator removal).

I don't see any XShape class.

@iverase
Copy link
Contributor

iverase commented Mar 14, 2024 •
edited
Loading

FWIW, CI was green with just the XTessellator removal

yeah, it was just for correctness. I think that's enough. If you are in a hurry I am good to merge, otherwise I will take a look on Monday,

iverase
iverase approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@iverase iverase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent benwtrent merged commit ee99b6c into elastic:7.17 Mar 18, 2024
10 checks passed
@benwtrent benwtrent deleted the feature/upgrade-to-latest-lucene-bugfix-release branch March 18, 2024 11:19
rprodan pushed a commit to rprodan/elasticsearch-analysis-lemmagen that referenced this pull request Mar 28, 2024
Updated Lucene version to 8.11.3 which was updated in Elastisearch 7.…
c8fe36d 
…17.19

See
- https://www.elastic.co/guide/en/elasticsearch/reference/7.17/release-notes-7.17.19.html
- elastic/elasticsearch#106365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecoop thecoop thecoop left review comments

@iverase iverase iverase approved these changes

Assignees
No one assigned
Labels
>bug :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v7.17.19
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benwtrent @elasticsearchmachine @iverase @thecoop