Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESQL: Rename SHOW FUNCTIONS to META FUNCTIONS #106362

Merged
merged 3 commits into from
Mar 19, 2024
Merged

ESQL: Rename SHOW FUNCTIONS to META FUNCTIONS #106362

merged 3 commits into from
Mar 19, 2024

Conversation

bpintea
Copy link
Contributor

@bpintea bpintea commented Mar 14, 2024

This renames the show functions command to meta functions.
It also removes its documentation.

Closes #100146.

@bpintea
Rename SHOW FUNCTIONS to META FUNCTIONS
87c0250 
This renames the `show functions` command to `meta functions`.
It also removes its documentation and usage tracking.
@github-actions GitHub Actions
Copy link
Contributor

Documentation preview:

@bpintea bpintea changed the title Rename SHOW FUNCTIONS to META FUNCTIONS ESQL: Rename SHOW FUNCTIONS to META FUNCTIONS Mar 14, 2024
bpintea added 2 commits March 14, 2024 20:07
@bpintea
Introduce META metric
ba836e1 
Introduce metric for META.
Revert unintentional changes.
@bpintea
Update telemetry tests
625e9e3
costin
costin reviewed Mar 14, 2024
View reviewed changes
Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bpintea bpintea marked this pull request as ready for review March 18, 2024 08:41
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Mar 18, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@stratoula stratoula added the ES|QL-ui Impacts ES|QL UI label Mar 18, 2024
@costin costin requested a review from astefan March 18, 2024 14:59
costin
costin approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

astefan
astefan approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bpintea
Copy link
Contributor Author

bpintea commented Mar 19, 2024

Thanks Costin, Andrei!

@bpintea bpintea merged commit 1fbb085 into elastic:main Mar 19, 2024
14 checks passed
@bpintea bpintea deleted the esql/show_functions-to-meta_functions branch March 19, 2024 12:02
This was referenced Mar 21, 2024
Closed
Merged
Merged
@leemthompo
Copy link
Contributor

@bpintea I don't have context on this one, but is this an internal name change? Because the docs weren't updated to rename to META

@bpintea
Copy link
Contributor Author

bpintea commented Apr 10, 2024

@leemthompo, the META function(s) are meant for internal consumption only, so don't need to be documented. But a similar functionality to the removed one will be reintroduced and then documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astefan astefan astefan approved these changes

@costin costin costin approved these changes

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL ES|QL-ui Impacts ES|QL UI >refactoring Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESQL: Show functions ergonomics
6 participants
@bpintea @elasticsearchmachine @leemthompo @costin @astefan @stratoula