Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename LocalExchangeSink and LocalExchangeSource #106245

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Mar 12, 2024

These should not have the term Local.

@dnhatn dnhatn requested a review from ChrisHegarty March 12, 2024 15:26
@dnhatn dnhatn marked this pull request as ready for review March 12, 2024 15:26
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Mar 12, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented Mar 12, 2024

Thanks Chris!

@dnhatn dnhatn merged commit e42e47e into elastic:main Mar 12, 2024
14 checks passed
@dnhatn dnhatn deleted the rename branch March 12, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants