Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce BWC testing to include only latest patch releases #106143

Merged
merged 6 commits into from
Mar 27, 2024

Conversation

mark-vieira
Copy link
Contributor

This commit alters our backward compatibility testing logic to restrict testing to the latest patch release for any given minor version. Since our policy is not to do any kind of breaking changes in patches, most of this testing is superfluous. This change reduces the number of versions we need to test by over 70%.

This commit alters our backward compatibility testing logic to restrict
testing to the latest patch release for any given minor version. Since
our policy is not to do any kind of breaking changes in patches, most of
this testing is superfluous. This change reduces the number of versions
we need to test by over 70%.
@breskeby
Copy link
Contributor

breskeby commented Mar 9, 2024

I think this makes sense and removing the intermediate patches safes us time and money while only giving very little value.
Do we have (anecdotal) historical data these tests between patches ever uncovered an actual BWC issue?

If we want to be 100% sure we do not break compatibility between patches we could probably test compatibility between patch releases when releasing the actual patch. Meaning when releasing 8.10.4 we test it is 100% compatible with 8.10.3.

@brianseeders
Copy link
Contributor

brianseeders commented Mar 14, 2024

Tests that rarely, if ever, provide any kind of useful signal should be run less often or never (depending on the cost/risk of missing something they might have caught).

I don't have the knowledge or data to say if they can be removed entirely, but it sounds like they could at least be moved to being tested weekly, if not removed entirely.

Moving to 1x per week would still cut the infrastructure cost of testing these versions by about 95%. But, again, they should just be removed if they aren't useful

# Conflicts:
#	.buildkite/pipelines/periodic-packaging.yml
#	.buildkite/pipelines/periodic.yml
#	.ci/bwcVersions
@mark-vieira mark-vieira marked this pull request as ready for review March 27, 2024 16:49
@mark-vieira mark-vieira requested a review from a team as a code owner March 27, 2024 16:49
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@elasticsearchmachine elasticsearchmachine added the Team:Delivery Meta label for Delivery team label Mar 27, 2024
@mark-vieira mark-vieira merged commit b1e4407 into elastic:main Mar 27, 2024
14 checks passed
mark-vieira added a commit that referenced this pull request Mar 27, 2024
This commit alters our backward compatibility testing logic to restrict
testing to the latest patch release for any given minor version. Since
our policy is not to do any kind of breaking changes in patches, most of
this testing is superfluous. This change reduces the number of versions
we need to test by over 70%.
mark-vieira added a commit that referenced this pull request Mar 27, 2024
mark-vieira added a commit that referenced this pull request Mar 27, 2024
(cherry picked from commit 392a759)
mark-vieira added a commit that referenced this pull request Mar 27, 2024
This commit alters our backward compatibility testing logic to restrict
testing to the latest patch release for any given minor version. Since
our policy is not to do any kind of breaking changes in patches, most of
this testing is superfluous. This change reduces the number of versions
we need to test by over 70%.

(cherry picked from commit b1e4407)
mark-vieira added a commit that referenced this pull request Mar 27, 2024
(cherry picked from commit 392a759)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v7.17.20 v8.13.1 v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants