Specialize serialization for ArrayVectors #105893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
force-pushed
the
serialize-vectors
branch
3 times, most recently
from
e1f9b7a to
5e18be5
Compare
dnhatn
force-pushed
the
serialize-vectors
branch
from
5e18be5 to
3ff58b7
Compare
dnhatn
commented
Mar 7, 2024
| @@ -30,6 +34,25 @@ final class BytesRefArrayVector extends AbstractVector implements BytesRefVector | |||
| this.values = values; | |||
| } | |||
|
|
|||
| static BytesRefArrayVector readArrayVector(int positions, StreamInput in, BlockFactory blockFactory) throws IOException { | |||
| final BytesRefArray values = new BytesRefArray(in, blockFactory.bigArrays()); | |||
There was a problem hiding this comment.
This is the main improvement in this PR. The rest is for a follow-up where we will implement specialized serialization for ArrayBlock.
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @dnhatn, I've created a changelog YAML for you. |
nik9000
approved these changes
Mar 7, 2024
x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/data/Vector.java
Show resolved
Hide resolved
|
Thanks Nik! |
ChrisHegarty
reviewed
Mar 8, 2024
dnhatn
added a commit
that referenced
this pull request
Mar 9, 2024
A follow-up of #105893 Currently, we serialize blocks value by value, which is simple but effective. However, it would be more efficient to serialize the underlying structures of array blocks instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we serialize blocks and vectors value by value, employing a simple yet effective approach. However, there are specific cases where we can enhance performance by serializing the underlying structure instead:
firstValueIndexes,nullsMask, and the underlying vector of an ArrayBlock instead of rebuilding the block from values.This PR addresses the first bullet point and lays the groundwork for implementing the second.