Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulate Mapper.Builder#name and make it private #105648

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

felixbarny
Copy link
Member

This is in preparation to make the field mutable,
which is needed in the context of #103542

This is in preparation to make the field mutable,
which is needed in the context of elastic#103542
@felixbarny felixbarny added >non-issue :Search Foundations/Mapping Index mappings, including merging and defining field types labels Feb 20, 2024
@felixbarny felixbarny requested a review from javanna February 20, 2024 10:56
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine elasticsearchmachine added Team:Search Meta label for search team v8.14.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Feb 20, 2024
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@felixbarny felixbarny merged commit 5920c91 into elastic:main Feb 20, 2024
14 checks passed
@felixbarny felixbarny deleted the encapsulate-mapper-builder-name branch February 20, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Meta label for search team v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants