Extract common ServiceSettings methods #105553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosdelest
commented
Feb 15, 2024
| @@ -252,7 +251,7 @@ public void chunkedInfer( | |||
|
|
|||
| var configUpdate = chunkingOptions.settingsArePresent() | |||
| ? new TokenizationConfigUpdate(chunkingOptions.windowSize(), chunkingOptions.span()) | |||
| : TextExpansionConfigUpdate.EMPTY_UPDATE; | |||
| : TextEmbeddingConfigUpdate.EMPTY_INSTANCE; | |||
There was a problem hiding this comment.
Fixed this bug for inference
carlosdelest
added
>refactoring
:ml
elasticsearchmachine
added
needs:triage
|
Pinging @elastic/ml-core (Team:ML) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is previous work for #105515.
Refactor out some common methods in
ServiceSettingsclass so they are available for serialization as part of inference results insemantic_text.When serializing dense vectors, inference results for semantic_text must include similarity and dimensions so the underlying field mapping can be properly created.
A new class is created to just serialize the information needed from
ServiceSettings. This means moving SimilarityMeasure to server code so it's available there as well.