[ci] Attach correct build artifact link to build scan when multiple are uploaded #105530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianseeders
added
>non-issue
Team:Delivery
|
Pinging @elastic/es-delivery (Team:Delivery) |
mark-vieira
approved these changes
Feb 14, 2024
| String[] partsB = b.split(" "); | ||
| // ISO-8601 timestamps can be sorted lexicographically | ||
| return partsA[1].compareTo(partsB[1]); | ||
| }).toList(); |
There was a problem hiding this comment.
nit: I think we can simplify this somewhat by sorting in reverse order and calling findFirst() instead of toList() since we only care about the most recent one.
brianseeders
added a commit
to brianseeders/elasticsearch
that referenced
this pull request
Feb 23, 2024
…re uploaded (elastic#105530) (cherry picked from commit e568f70)
brianseeders
added a commit
to brianseeders/elasticsearch
that referenced
this pull request
Feb 23, 2024
…re uploaded (elastic#105530) (cherry picked from commit e568f70)
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some jobs upload multiple artifacts, which messes up the link that gets attached to the build scan (because all of the artifact IDs get appended together).