[test] Don't reuse index name as restored index #105450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid conflicts with correct cleanup of shared folders
arteam
added
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed (Team:Distributed) |
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
| @@ -98,7 +98,7 @@ public void testCreateAndRestoreSearchableSnapshot() throws Exception { | |||
| final String fsRepoName = randomAlphaOfLength(10); | |||
| final String indexName = randomAlphaOfLength(10).toLowerCase(Locale.ROOT); | |||
| final String aliasName = randomAlphaOfLength(10).toLowerCase(Locale.ROOT); | |||
| final String restoredIndexName = randomBoolean() ? indexName : randomAlphaOfLength(10).toLowerCase(Locale.ROOT); | |||
| final String restoredIndexName = randomAlphaOfLength(10).toLowerCase(Locale.ROOT); | |||
There was a problem hiding this comment.
I think it is valid to reuse the same name, since following closes or deletes original index before restore:
|
@elasticmachine update branch |
|
Superceded by #105731 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid conflicts with correct cleanup of shared folders
Resolve #105202