Reduce InternalHistogram and InternalDateHistogram in a streaming fashion #105359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
nik9000
approved these changes
Feb 9, 2024
...asticsearch/search/aggregations/bucket/histogram/HistogramMultiBucketsAggregatorReducer.java
Outdated
Show resolved
Hide resolved
...asticsearch/search/aggregations/bucket/histogram/HistogramMultiBucketsAggregatorReducer.java
Outdated
Show resolved
Hide resolved
...asticsearch/search/aggregations/bucket/histogram/HistogramMultiBucketsAggregatorReducer.java
Outdated
Show resolved
Hide resolved
|
Also! I think it'd be good to wait until next week to merge this so we can get a couple of overnight runs with the last few changes. |
This was referenced May 2, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to #105348 InternalHistogram and InternalDateHistogram can be wasteful and can be reduced in a streaming fashion. In this case we introduce a HistogramMultiBucketsAggregatorReducer to do the job.
This change might be more controversial because we change from collecting buckets on a priority queue to use a
LongObjectPagedHashMapto keep track of the reduced buckets. I feel this approach will be faster but I lack of feeling of the performance profile ofLongObjectPagedHashMap.relates #105207