ESQL: Refactor EsqlTranslatorHandler #105230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to translate an out-of-range comparison first; if the translation does not apply, delegate directly to ExpressionTranslators.BinaryComparisons, rather than having two separate rules.
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
|
Maybe we also want to backport this to 8.12 - so that other potential backports come with fewer merge conflicts. |
not-napoleon
added a commit
that referenced
this pull request
Mar 12, 2024
Bbuilding on the work @alex-spies did in #105230 to start to decouple the ESQL translation layer from the QL translation layer. I did this by straight up copying the QL binary comparison code from ExpressionTranslators.BinaryComparisons to EsqlExpressionTranslators.BinaryComparisons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactoring suggested by @costin:
QueryTranslatorand the generalExpressionTranslatorsclass in the QL project.TrivialBinaryComparisonandExpressionTranslators.BinaryComparisonsby a single translator handler that delegates toExpressionTranslators.BinaryComparisonsif necessary. This is in line with other customized translators, e.g.Scalars(both ESQL's and EQL's).Note to reviewers: Probably it's easiest to view the two commits separately; each of them is highly mechanical by itself.