Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transform] Allow transforms to use PIT with remote clusters again #105192

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Feb 6, 2024

There used to be problems with transforms using PIT together with remote source indices.
The mitigation was #99803.
Then the underlying issue got fixed so the mitigation can be reverted.
This PR does exactly this.

Closes #104518

@przemekwitek przemekwitek force-pushed the revert_pit_restriction branch from 92d8756 to 57f1264 Compare February 6, 2024 15:06
@przemekwitek przemekwitek marked this pull request as ready for review February 6, 2024 15:09
@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Feb 6, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @przemekwitek, I've created a changelog YAML for you.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@przemekwitek przemekwitek added >enhancement and removed Team:ML Meta label for the ML team >bug labels Feb 6, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @przemekwitek, I've updated the changelog YAML for you.

@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Feb 6, 2024
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@przemekwitek przemekwitek merged commit 9b584aa into elastic:main Feb 6, 2024
15 checks passed
@przemekwitek przemekwitek deleted the revert_pit_restriction branch February 6, 2024 17:30
prwhelan added a commit to prwhelan/elasticsearch that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :ml/Transform Transform Team:ML Meta label for the ML team v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Transform] Allow transforms to use PIT with remote clusters again
3 participants