Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move semantic_text mappers to Inference plugin #105187

Conversation

carlosdelest
Copy link
Member

We started work on the semantic_text PoC using the actions provided from the ML plugin APIs.

semantic_text will use inference operations from the Inference plugin, so it makes sense to move mappers there.

@carlosdelest carlosdelest marked this pull request as ready for review February 6, 2024 14:33
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Feb 6, 2024
@carlosdelest carlosdelest added >non-issue :Search Foundations/Mapping Index mappings, including merging and defining field types >refactoring labels Feb 6, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Feb 6, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Feb 6, 2024
@carlosdelest carlosdelest added the needs:triage Requires assignment of a team area label label Feb 6, 2024
@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Feb 6, 2024
@Mikep86 Mikep86 added the v8.13.0 label Feb 6, 2024
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, this should also simplify the testing going forward.

@carlosdelest
Copy link
Member Author

+1, this should also simplify the testing going forward.

;) This was my primary purpose, to create integration tests as part of #103697 👍

@carlosdelest carlosdelest merged commit e3b6a65 into elastic:feature/semantic-text Feb 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>non-issue >refactoring :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Meta label for search team v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants