Support non-keyword fields as dimension subfields of pass-through object #105073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkrik-es
added
>enhancement
:StorageEngine/TSDB
|
Hi @kkrik-es, I've created a changelog YAML for you. |
# Conflicts: # server/src/test/java/org/elasticsearch/index/mapper/RootObjectMapperTests.java
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
reviewed
Feb 9, 2024
| @@ -334,16 +334,13 @@ private void extractItem(String path, XContentParser source) throws IOException | |||
| source.nextToken(); | |||
| break; | |||
| case VALUE_STRING: | |||
| case VALUE_NUMBER: | |||
| hashes.add(new NameAndHash(new BytesRef(path), hash(new BytesRef(source.text())))); | |||
There was a problem hiding this comment.
This isn't related to this change, but I think we should delegate to addMatching(...) here? Otherwise all fields are taken into account while hashing?
# Conflicts: # modules/data-streams/src/yamlRestTest/resources/rest-api-spec/test/data_stream/150_tsdb.yml
# Conflicts: # server/src/main/java/org/elasticsearch/index/mapper/TsidExtractingIdFieldMapper.java
# Conflicts: # rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/tsdb/20_mapping.yml # server/src/main/java/org/elasticsearch/index/mapper/TsidExtractingIdFieldMapper.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up on #103648, lifting the limitation that the pass-through object can contain only keyword fields if it's marked as
time_series_dimension.This requires updating non-keyword fields in the routing path to be included in routing calculations. The routing id in the TSDB _id (first 4 bytes) gets updated to be the shard id, so that there are no routing inconsistencies between the coordinating (without mappings) and the data (with mappings) nodes.
Related to #103567