-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS][ESQL] Document case insensitive equals operator #105031
base: main
Are you sure you want to change the base?
Conversation
Documentation preview: |
@@ -3,14 +3,25 @@ | |||
=== Binary operators | |||
|
|||
[[esql-binary-operators-equality]] | |||
==== Equality | |||
==== Equality `==` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚗
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-analytical-engine (Team:Analytics) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @leemthompo, I left a comment about a small improvement.
Partially unrelated to this PR, I also noticed that the type tables for binary operators only report integer, integer
as valid inputs, while most of the operators accept any type, and =~
does not accept numbers at all.
I think it's something we'll have to double-check, probably @nik9000 has a quick pointer
@luigidellaquila I'll create an issue to look into this separately 👍 |
@nik9000 not sure how to proceed here with regards the railroad diagrams |
This is because we don't have tests for those types. @not-napoleon is working on that. |
The reason we don't have a railroad diagram and type table is that those come from building a subclass of |
Blocked because currently disabled. See #105603.