-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Transform] Make _reset
action stop transforms without force first
#104870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/ml-core (Team:ML) |
Hi @przemekwitek, I've created a changelog YAML for you. |
prwhelan
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reduce logging level from warn to info.
…k/elasticsearch into fix_reset_transforms
przemekwitek
added
v8.12.1
auto-backport
Automatically create backport pull requests when merged
labels
Jan 30, 2024
💚 Backport successful
|
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Jan 30, 2024
przemekwitek
added a commit
that referenced
this pull request
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
>bug
:ml/Transform
Transform
Team:ML
Meta label for the ML team
v8.12.1
v8.13.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
_reset
action the following way:_reset
action now tries to_stop
the transform withoutforce
but with timeoutforce
set totrue
Additionally, this PR unmutes the
TestFeatureResetIT
test case.This PR will be backported to
8.12
once the test runs without failure for a week in main.Closes #100596
Closes #104825