Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transform] Make _reset action stop transforms without force first #104870

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Jan 29, 2024

This PR fixes _reset action the following way:

  • the _reset action now tries to _stop the transform without force but with timeout
  • only when this fails, it re-tries, this time with force set to true

Additionally, this PR unmutes the TestFeatureResetIT test case.

This PR will be backported to 8.12 once the test runs without failure for a week in main.

Closes #100596
Closes #104825

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@elasticsearchmachine
Copy link
Collaborator

Hi @przemekwitek, I've created a changelog YAML for you.

@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Jan 29, 2024
Copy link
Member

@prwhelan prwhelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@przemekwitek przemekwitek added v8.12.1 auto-backport Automatically create backport pull requests when merged labels Jan 30, 2024
@przemekwitek przemekwitek merged commit 44d5035 into elastic:main Jan 30, 2024
15 checks passed
@przemekwitek przemekwitek deleted the fix_reset_transforms branch January 30, 2024 09:24
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.12

przemekwitek added a commit to przemekwitek/elasticsearch that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >bug :ml/Transform Transform Team:ML Meta label for the ML team v8.12.1 v8.13.0
Projects
None yet
3 participants