[Connectors API] Fix bug when creating a sync job via API

[jedrazb]

Changes

• Fix Connector representation in ConnectorSyncJob class, the filtering field should only represent the active rules applied for a given sync job, otherwise it will cause a sync job to fail
• This should be backported to 8.12 as a bugfix
• Adapt tests
• Tested manually

Reproduction

• Create a connector
• Get its ID
• Trigger a on demand sync job via API , I could reproduce getting an error

[FMWK][15:49:32][ERROR] [Connector id: HUeGQI0BpfSJQu5aFEpG, index name: search-gdrive, Sync job id: KkcYQY0BpfSJQu5a9krZ] dictionary update sequence element #0 has length 3; 2 is required
Traceback (most recent call last):
  File "/Users/jedr/connectors-python/connectors/sync_job_runner.py", line 139, in execute
    await self._execute_content_sync_job(job_type, bulk_options)
  File "/Users/jedr/connectors-python/connectors/sync_job_runner.py", line 195, in _execute_content_sync_job
    await self.sync_job.validate_filtering(validator=self.data_provider)
  File "/Users/jedr/connectors-python/connectors/protocol/connectors.py", line 290, in validate_filtering
    validation_result = await validator.validate_filtering(self.filtering)
  File "/Users/jedr/connectors-python/connectors/protocol/connectors.py", line 252, in filtering
    return Filter(self.get("connector", "filtering", default={}))
  File "/Users/jedr/connectors-python/connectors/protocol/connectors.py", line 413, in __init__
    super().__init__(filter_)
ValueError: dictionary update sequence element #0 has length 3; 2 is required

• Kibana selects only active filtering property before writing the sync job in the index, see https://github.com/elastic/kibana/blob/main/packages/kbn-search-connectors/lib/start_sync.ts#L65
• We don't do it in connectors api and it's causing issues

[elasticsearchmachine]

Hi @jedrazb, I've created a changelog YAML for you.

[elasticsearchmachine]

Pinging @elastic/ent-search-eng (Team:Enterprise Search)

[timgrein]

LGTM 🚀

[elasticsearchmachine]

💔 Backport failed

Status	Branch	Result
❌	8.12	Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 104802

[jedrazb]

💚 All backports created successfully

Status	Branch	Result
✅	8.12

Questions ?

Please refer to the Backport tool documentation