-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skip tags to three tests to prevent them from being run on versions older than 8.13.0 #104780
Merged
luigidellaquila
merged 10 commits into
elastic:main
from
fang-xing-esql:skip_tests_on_older_versions
Jan 26, 2024
Merged
Add skip tags to three tests to prevent them from being run on versions older than 8.13.0 #104780
luigidellaquila
merged 10 commits into
elastic:main
from
fang-xing-esql:skip_tests_on_older_versions
Jan 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_bucket Committer: Fang Xing <[email protected]>
fang-xing-esql
added
>test-failure
Triaged test failures from CI
:Analytics/ES|QL
AKA ESQL
v8.13.0
labels
Jan 25, 2024
elasticsearchmachine
added
blocker
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
labels
Jan 25, 2024
Pinging @elastic/es-analytical-engine (Team:Analytics) |
fang-xing-esql
changed the title
Add skip tags to there tests to prevent them from being run on versions older than 8.13.0
Add skip tags to three tests to prevent them from being run on versions older than 8.13.0
Jan 25, 2024
luigidellaquila
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@fang-xing-esql thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Analytics/ES|QL
AKA ESQL
blocker
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
>test-failure
Triaged test failures from CI
v8.13.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #104776
The three failed tests reported in #104776 are not expected to return successfully on versions older than 8.13.0, as the support to allow date type on the from and to input parameters of AUTO_BUCKET is introduced on 8.13.0.