Stop capturing the BucketAggregator when building internal sub-aggregations #104758
+26
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I notice that when building internal subaggregation using the method BucketAggregator#buildSubAggsForBuckets, we are capturing the current BucketAggregator when we create the Abstract list. This means we are holding for much longer the object which can be pretty big, as seen in this heap dump extract:
This PR adds a static inner class to avoid capturing the BucketAggregator.