Make RestResponse releasable #104752
Merged
Make RestResponse releasable #104752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On reflection is was probably a mistake to give each `ChunkedRestResponseBody` a nontrivial lifecycle in elastic#99871. The lifecycle really belongs to the whole containing `RestResponse`. This commit moves it there.
DaveCTurner
added
>non-issue
:Distributed Coordination/Network
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Thanks @arteam! |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 27, 2024
Related to elastic#104752, we should not be confounding the lifecycle of the `EncodedLengthTrackingChunkedRestResponseBody` with the lifecycle of the overall `RestResponse`. This commit introduces a separate object to record the total response length whose lifecycle is independent of that of the response body.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 29, 2024
Related to #104752, we should not be confounding the lifecycle of the `EncodedLengthTrackingChunkedRestResponseBody` with the lifecycle of the overall `RestResponse`. This commit introduces a separate object to record the total response length whose lifecycle is independent of that of the response body.
|
FWIW this was opened to prepare things for #104851. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On reflection is was probably a mistake to give each
ChunkedRestResponseBodya nontrivial lifecycle in #99871. Thelifecycle really belongs to the whole containing
RestResponse. Thiscommit moves it there.