[ML] Close inference services #104726
Merged
[ML] Close inference services #104726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-buttner
added
>non-issue
:ml
| @@ -20,7 +20,7 @@ | |||
| import java.util.function.Function; | |||
| import java.util.stream.Collectors; | |||
|
|
|||
| public class InferenceServiceRegistry extends AbstractLifecycleComponent { | |||
There was a problem hiding this comment.
I don't believe we need this to be an AbstractLifecycleComponent anymore since it's not part of the NodeConstruction class right?
|
What is the purpose of |
Yeah and we have some background threads that run and it shuts those down as well. |
|
@elasticmachine run elasticsearch-ci/part-1 |
|
@elasticmachine merge upstream |
|
Pinging @elastic/ml-core (Team:ML) |
henningandersen
pushed a commit
to henningandersen/elasticsearch
that referenced
this pull request
Jan 25, 2024
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up some logic and adds functionality to close the inference services when the
InferencePlugin::close()is called. This removes the need to keep a reference to theHttpClientManagersince it'll be closed by the individual services. This helps prepare the batching logic to have a separate http pool for searching and ingest.