ESQL: Fix replacement of nested expressions in aggs with multiple parameters #104718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v8.13.0
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @luigidellaquila, I've created a changelog YAML for you. |
bpintea
approved these changes
Jan 24, 2024
|
@elasticmachine run elasticsearch-ci/part-3 |
|
@bpintea good point, we have tests for count_distinct(), but not with nested expressions. |
henningandersen
pushed a commit
to henningandersen/elasticsearch
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104706
Fixing a small regression after #104387
The rule that extracts nested expressions from aggs did not take extra params into consideration, resulting in an IndexOutOfBoundsException for functions like
percentile()that have more than one input parameter.