Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix testRestoreSnapshotAllocationDoesNotExceedWatermarkWithMultipleShards #104709

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Fix testRestoreSnapshotAllocationDoesNotExceedWatermarkWithMultipleShards #104709

merged 1 commit into from
Jan 25, 2024

Conversation

idegtiarenko
Copy link
Contributor

Remove +1L that allows the third-smallest shard to be also allocated on the node in case it is only 1b bigger than second-smallest.

Closes: #104703

@idegtiarenko
Fix testRestoreSnapshotAllocationDoesNotExceedWatermarkWithMultipleSh…
4d624c6 
…ards

Remove +1L that allows the third-smallest shard to be also allocated on the node
 in case it is only 1b bigger than second-smallest
@idegtiarenko idegtiarenko added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.13.0 labels Jan 24, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

kingherc
kingherc approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@kingherc kingherc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Similar to #93815 .

@idegtiarenko idegtiarenko merged commit a7f2e2d into elastic:main Jan 25, 2024
15 checks passed
@idegtiarenko idegtiarenko deleted the fix_104703 branch January 25, 2024 08:21
henningandersen pushed a commit to henningandersen/elasticsearch that referenced this pull request Jan 25, 2024
@idegtiarenko @henningandersen
Fix testRestoreSnapshotAllocationDoesNotExceedWatermarkWithMultipleSh…
4c585c4 
…ards (elastic#104709)

Remove +1L that allows the third-smallest shard to be also allocated on the node
 in case it is only 1b bigger than second-smallest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingherc kingherc kingherc approved these changes

Assignees
No one assigned
Labels
:Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] DiskThresholdDeciderIT testRestoreSnapshotAllocationDoesNotExceedWatermarkWithMultipleShards failing
3 participants
@idegtiarenko @elasticsearchmachine @kingherc