Fix precision issue in CI for cartesian centroids #104707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even with Kahan summation, there is a tiny precisoin loss. We already fixed this before for GeoPoint by using the encode/decode to doc-values quantization in the final display results, and for CartesianPoint we fix by casting the coordinates to float for both the expected and actual results.
craigtaverner
added
>test
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
iverase
reviewed
Jan 24, 2024
| if (type == CsvTestUtils.Type.GEO_POINT) { | ||
| // GeoPoint tests are failing in clustered integration tests because of tiny precision differences at very small scales | ||
| if (type == CsvTestUtils.Type.GEO_POINT || type == CsvTestUtils.Type.CARTESIAN_POINT) { | ||
| // Point tests are failing in clustered integration tests because of tiny precision differences at very small scales | ||
| if (value instanceof GeoPoint point) { |
There was a problem hiding this comment.
Can we really get a GeoPoint here? I would expect only WKT can get to this point?
There was a problem hiding this comment.
You are right, older code would have reached this, but I don't think the current code ever does. I could clean this up in another PR.
henningandersen
pushed a commit
to henningandersen/elasticsearch
that referenced
this pull request
Jan 25, 2024
Even with Kahan summation, there is a tiny precisoin loss. We already fixed this before for GeoPoint by using the encode/decode to doc-values quantization in the final display results, and for CartesianPoint we fix by casting the coordinates to float for both the expected and actual results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even with Kahan summation, there is a tiny precisoin loss. We already fixed this before for GeoPoint by using the encode/decode to doc-values quantization in the final display results, and for CartesianPoint we fix by casting the coordinates to float for both the expected and actual results.
Fixes #104690