Blob-cache get remove false negatives #104696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The blob cache would sometimes respond with an already closed exception even though regions could be made available. Fixed to only do so when there really are no available regions (which should never happen with region count > thread count, i.e., normally). One exception is explicit evict, which only happens on explicit clear cache or corruptions.
henningandersen
added
>enhancement
:Distributed Coordination/Snapshot/Restore
|
Hi @henningandersen, I've created a changelog YAML for you. |
|
Failure looks unrelated, filed it here: #104708 |
|
@elasticmachine run elasticsearch-ci/part-4 |
tlrx
reviewed
Jan 25, 2024
...ugin/blob-cache/src/main/java/org/elasticsearch/blobcache/shared/SharedBlobCacheService.java
Show resolved
Hide resolved
tlrx
reviewed
Jan 25, 2024
| return ioRef; | ||
| } | ||
| } finally { | ||
| unlink(entry); |
There was a problem hiding this comment.
This will also stop iterating over other entries with same freq. I think this is OK since we only try to evict 1 CacheFileRegion and take its IO but maybe we can add a return statement at the end of the if (evicted) { block to make it explicit that no more cache entries will be evaluated?
|
Will likely handle this in one PR in #104746 to avoid drip-wise changes. |
|
Handled in #104784 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The blob cache would sometimes respond with an already closed exception even though regions could be made available. Fixed to only do so when there really are no available regions (which should never happen with region count >= thread count, i.e., normally).
One exception is explicit evict, which only happens on explicit clear cache or corruptions.
Marked DRAFT for now to get input on approach, check that tests succeed and perhaps add a bit more testing.