ESQL: Reduce the number of Evals ReplaceMissingFieldWithNull creates #104669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lastic#104586) Improve ReplaceMissingFieldWithNull to create just one eval (per datatype) for the missing value and have the rest point to it. This reduces the amount of EvalOperators created in the pipeline. Preserve type information (one null eval per dataType) Fix subtle error in LocalPhysicalPlanOptimizer test Fix elastic#104583 (cherry picked from commit d6f900c)
costin
added
backport
:Analytics/ES|QL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#104586 backport
Improve ReplaceMissingFieldWithNull to create just one eval (per
datatype) for the missing value and have the rest point to it. This
reduces the amount of EvalOperators created in the pipeline.
Preserve type information (one null eval per dataType) Fix subtle error in LocalPhysicalPlanOptimizer test
(cherry picked from commit d6f900c)