-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Connectors API] Implement update service type action #104643
[Connectors API] Implement update service type action #104643
Conversation
Pinging @elastic/ent-search-eng (Team:Enterprise Search) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Potential follow-up: Should we think about a set of rules defining how you can define a service_type
syntactically? In the connectors framework we seem to implicitly use snake_case. WDYT?
...earch/src/main/java/org/elasticsearch/xpack/application/connector/ConnectorIndexService.java
Outdated
Show resolved
Hide resolved
…/application/connector/ConnectorIndexService.java Co-authored-by: Tim Grein <[email protected]>
@timgrein Yeah we follow snake_case pattern but I don't see us ever enforcing it anywhere in the connectors framework. Enforcing this on API level might break things for folks who deployed custom connectors with custom names. I prefer to not add this validation here. |
Hi @jedrazb, I've created a changelog YAML for you. |
Changes
_configuration
endpoint