Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Connectors API] Implement update service type action #104643

Merged

Conversation

jedrazb
Copy link
Member

@jedrazb jedrazb commented Jan 23, 2024

Changes

  • Update service type action endpoint, this functionality is expected by Kibana
_connector/{connector_id}/_service_type
{
  "service_type": ....
}
  • Service type change results in connector status change as well (created or needs_configuration)
  • Clearing configuration is caller's responsibility via _configuration endpoint
  • Add tests: unit, yml, bwc

@jedrazb jedrazb added >non-issue :EnterpriseSearch/Application Enterprise Search Team:Enterprise Search Meta label for Enterprise Search team v8.13.0 labels Jan 23, 2024
@jedrazb jedrazb marked this pull request as ready for review January 23, 2024 10:49
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ent-search-eng (Team:Enterprise Search)

@jedrazb jedrazb requested review from timgrein and sphilipse January 23, 2024 10:50
Copy link
Contributor

@timgrein timgrein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Potential follow-up: Should we think about a set of rules defining how you can define a service_type syntactically? In the connectors framework we seem to implicitly use snake_case. WDYT?

…/application/connector/ConnectorIndexService.java

Co-authored-by: Tim Grein <[email protected]>
@jedrazb
Copy link
Member Author

jedrazb commented Jan 24, 2024

In the connectors framework we seem to implicitly use snake_case. WDYT?

@timgrein Yeah we follow snake_case pattern but I don't see us ever enforcing it anywhere in the connectors framework. Enforcing this on API level might break things for folks who deployed custom connectors with custom names. I prefer to not add this validation here.

@elasticsearchmachine
Copy link
Collaborator

Hi @jedrazb, I've created a changelog YAML for you.

@jedrazb jedrazb merged commit d5c0dcf into elastic:main Jan 24, 2024
15 checks passed
henningandersen pushed a commit to henningandersen/elasticsearch that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :EnterpriseSearch/Application Enterprise Search Team:Enterprise Search Meta label for Enterprise Search team v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants