Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] Disable broken BA template in BwC test #104635

Merged
merged 6 commits into from
Jan 26, 2024

Conversation

demjened
Copy link
Contributor

@demjened demjened commented Jan 22, 2024

This PR disables the broken BWC test org.elasticsearch.xpack.application.FullClusterRestartIT. It applies changes from #104463 (cc @breskeby) after rebasing to main.

@elasticsearchmachine elasticsearchmachine added v8.13.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jan 22, 2024
@Mikep86 Mikep86 added :EnterpriseSearch/Application Enterprise Search Team:Enterprise Search Meta label for Enterprise Search team v8.12.0 and removed external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jan 22, 2024
@demjened demjened force-pushed the demjened/fix-ba-template-in-bwc branch from f76388a to 018f8ef Compare January 24, 2024 21:43
@demjened demjened changed the title [WIP] Fix broken BA template in BwC test [Enterprise Search] Fix broken BA template in BwC test Jan 25, 2024
@demjened demjened marked this pull request as ready for review January 25, 2024 14:54
@demjened demjened requested a review from a team as a code owner January 25, 2024 14:54
@demjened demjened requested review from afoucret and Mikep86 January 25, 2024 14:54
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ent-search-eng (Team:Enterprise Search)

@Mikep86 Mikep86 added the >bug label Jan 25, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @demjened, I've created a changelog YAML for you.

@kderusso
Copy link
Member

@demjened I think we want to label this >test-failure and not generate a changelog here.

@demjened demjened added >test-failure Triaged test failures from CI and removed >bug labels Jan 25, 2024
@demjened demjened force-pushed the demjened/fix-ba-template-in-bwc branch from 3d03c34 to d7bdd1e Compare January 26, 2024 16:28
@demjened demjened added v8.12.1 and removed v8.12.0 labels Jan 26, 2024
@demjened demjened requested a review from mark-vieira January 26, 2024 16:53
Copy link
Contributor

@Mikep86 Mikep86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you change the title of the PR since we aren't actually fixing the test?

@demjened demjened changed the title [Enterprise Search] Fix broken BA template in BwC test [Enterprise Search] Disable broken BA template in BwC test Jan 26, 2024
@demjened demjened merged commit 8927a1a into elastic:main Jan 26, 2024
15 checks passed
@demjened
Copy link
Contributor Author

@breskeby - FYI this PR contains your changes, passed CI and has been merged. Feel free to close yours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker :EnterpriseSearch/Application Enterprise Search Team:Enterprise Search Meta label for Enterprise Search team >test-failure Triaged test failures from CI v8.12.1 v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants