Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Profiling] Refine co2 calculation data #104628

Merged
merged 15 commits into from
Jan 25, 2024
Merged

Conversation

rockdaboot
Copy link
Contributor

The PR updates the CO2 emission data with values and region names taken from https://github.com/PaoloFrigo/cloud-carbon-footprint.

@rockdaboot rockdaboot self-assigned this Jan 22, 2024
@elasticsearchmachine elasticsearchmachine added Team:obs-knowledge Meta label for Observability Knowledge team external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jan 22, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/obs-knowledge-team (Team:obs-knowledge)

@rockdaboot rockdaboot removed the external-contributor Pull request authored by a developer outside the Elasticsearch team label Jan 22, 2024
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all the changes look good to me (we'll figure out the failing license check). I left one minor comment in the code.

@rockdaboot rockdaboot requested a review from a team as a code owner January 25, 2024 08:00
@rockdaboot
Copy link
Contributor Author

@elasticmachine merge upstream

elasticsearchmachine pushed a commit that referenced this pull request Jan 25, 2024
if there are no dependencies declared and the license file is marked as
ignored, no exception should be thrown and dependencylicense check
should pass.

Fixes issues we identified in #104628
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Jan 25, 2024
if there are no dependencies declared and the license file is marked as
ignored, no exception should be thrown and dependencylicense check
should pass.

Fixes issues we identified in elastic#104628
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Jan 25, 2024
if there are no dependencies declared and the license file is marked as
ignored, no exception should be thrown and dependencylicense check
should pass.

Fixes issues we identified in elastic#104628
@rockdaboot
Copy link
Contributor Author

@elasticmachine merge upstream

elasticsearchmachine pushed a commit that referenced this pull request Jan 25, 2024
if there are no dependencies declared and the license file is marked as
ignored, no exception should be thrown and dependencylicense check
should pass.

Fixes issues we identified in #104628
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me. Once CI / license check is happy this seems good to merge.

@rockdaboot rockdaboot merged commit 048fa93 into elastic:main Jan 25, 2024
15 checks passed
rockdaboot added a commit to rockdaboot/elasticsearch that referenced this pull request Jan 25, 2024
* Add CO2 data for AWS ap-southeast-3 and me-central-1

* Update CO2 data for GCP including new regions

* Update CO2 data for Azure including new/changed regions

* Move provider data into CloudProviders.java

* Add NOTICE and LICENSE for the provider data

* Document CloudProviders' public functions

* Add cloudcarbonfootprint-(NOTICE|LICENSE).txt as ignoreFile

---------

Co-authored-by: Elastic Machine <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Jan 25, 2024
* Add CO2 data for AWS ap-southeast-3 and me-central-1

* Update CO2 data for GCP including new regions

* Update CO2 data for Azure including new/changed regions

* Move provider data into CloudProviders.java

* Add NOTICE and LICENSE for the provider data

* Document CloudProviders' public functions

* Add cloudcarbonfootprint-(NOTICE|LICENSE).txt as ignoreFile

---------

Co-authored-by: Elastic Machine <[email protected]>
henningandersen pushed a commit to henningandersen/elasticsearch that referenced this pull request Jan 25, 2024
if there are no dependencies declared and the license file is marked as
ignored, no exception should be thrown and dependencylicense check
should pass.

Fixes issues we identified in elastic#104628
henningandersen pushed a commit to henningandersen/elasticsearch that referenced this pull request Jan 25, 2024
* Add CO2 data for AWS ap-southeast-3 and me-central-1

* Update CO2 data for GCP including new regions

* Update CO2 data for Azure including new/changed regions

* Move provider data into CloudProviders.java

* Add NOTICE and LICENSE for the provider data

* Document CloudProviders' public functions

* Add cloudcarbonfootprint-(NOTICE|LICENSE).txt as ignoreFile

---------

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement Team:obs-knowledge Meta label for Observability Knowledge team :UniversalProfiling/Application Elastic Universal Profiling REST APIs and infrastructure v8.12.1 v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants