-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Profiling] Refine co2 calculation data #104628
Conversation
Pinging @elastic/obs-knowledge-team (Team:obs-knowledge) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all the changes look good to me (we'll figure out the failing license check). I left one minor comment in the code.
x-pack/plugin/profiling/src/main/java/org/elasticsearch/xpack/profiling/CloudProviders.java
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
if there are no dependencies declared and the license file is marked as ignored, no exception should be thrown and dependencylicense check should pass. Fixes issues we identified in #104628
if there are no dependencies declared and the license file is marked as ignored, no exception should be thrown and dependencylicense check should pass. Fixes issues we identified in elastic#104628
if there are no dependencies declared and the license file is marked as ignored, no exception should be thrown and dependencylicense check should pass. Fixes issues we identified in elastic#104628
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look good to me. Once CI / license check is happy this seems good to merge.
* Add CO2 data for AWS ap-southeast-3 and me-central-1 * Update CO2 data for GCP including new regions * Update CO2 data for Azure including new/changed regions * Move provider data into CloudProviders.java * Add NOTICE and LICENSE for the provider data * Document CloudProviders' public functions * Add cloudcarbonfootprint-(NOTICE|LICENSE).txt as ignoreFile --------- Co-authored-by: Elastic Machine <[email protected]>
* Add CO2 data for AWS ap-southeast-3 and me-central-1 * Update CO2 data for GCP including new regions * Update CO2 data for Azure including new/changed regions * Move provider data into CloudProviders.java * Add NOTICE and LICENSE for the provider data * Document CloudProviders' public functions * Add cloudcarbonfootprint-(NOTICE|LICENSE).txt as ignoreFile --------- Co-authored-by: Elastic Machine <[email protected]>
if there are no dependencies declared and the license file is marked as ignored, no exception should be thrown and dependencylicense check should pass. Fixes issues we identified in elastic#104628
* Add CO2 data for AWS ap-southeast-3 and me-central-1 * Update CO2 data for GCP including new regions * Update CO2 data for Azure including new/changed regions * Move provider data into CloudProviders.java * Add NOTICE and LICENSE for the provider data * Document CloudProviders' public functions * Add cloudcarbonfootprint-(NOTICE|LICENSE).txt as ignoreFile --------- Co-authored-by: Elastic Machine <[email protected]>
The PR updates the CO2 emission data with values and region names taken from https://github.com/PaoloFrigo/cloud-carbon-footprint.