Avoid execute ESQL planning on refresh thread #104591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dnhatn, I've created a changelog YAML for you. |
dnhatn
commented
Jan 21, 2024
| @@ -585,6 +594,7 @@ public void messageReceived(DataNodeRequest request, TransportChannel channel, T | |||
| configuration, | |||
| request.aliasFilters(), | |||
| ActionListener.wrap(searchContexts -> { | |||
| assert ThreadPool.assertCurrentThreadPool(ESQL_THREAD_POOL_NAME); | |||
There was a problem hiding this comment.
Without the fix, the test EsqlActionIT#testRefreshSearchIdleShards trips this assertion .
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
nik9000
approved these changes
Jan 25, 2024
| @@ -585,6 +594,7 @@ public void messageReceived(DataNodeRequest request, TransportChannel channel, T | |||
| configuration, | |||
| request.aliasFilters(), | |||
| ActionListener.wrap(searchContexts -> { | |||
| assert ThreadPool.assertCurrentThreadPool(ESQL_THREAD_POOL_NAME); | |||
|
Thanks, Nik! |
|
Backported to 8.12 in #104773 |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jan 25, 2024
A recent report shows that we can perform ESQL planning on the refresh thread pool after waiting for refreshes from search-idle shards. While the planning process is generally lightweight, it may become expensive at times. Therefore, we should fork off the refresh thread pool immediately upon resuming ESQL execution. Another place where we should fork off is after field_caps. I will look into that later.
henningandersen
pushed a commit
to henningandersen/elasticsearch
that referenced
this pull request
Jan 25, 2024
A recent report shows that we can perform ESQL planning on the refresh thread pool after waiting for refreshes from search-idle shards. While the planning process is generally lightweight, it may become expensive at times. Therefore, we should fork off the refresh thread pool immediately upon resuming ESQL execution. Another place where we should fork off is after field_caps. I will look into that later.
dnhatn
added a commit
that referenced
this pull request
Jan 26, 2024
A recent report shows that we can perform ESQL planning on the refresh thread pool after waiting for refreshes from search-idle shards. While the planning process is generally lightweight, it may become expensive at times. Therefore, we should fork off the refresh thread pool immediately upon resuming ESQL execution. Another place where we should fork off is after field_caps. I will look into that later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent report shows that we can perform ESQL planning on the refresh thread pool after waiting for refreshes from search-idle shards. While the planning process is generally lightweight, it may become expensive at times. Therefore, we should fork off the refresh thread pool immediately upon resuming ESQL execution. Another place where we should fork off is after field_caps. I will look into that later.