Remove allocations from TimeBasedUUIDGenerator #104584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to use a capturing lambda here, als no need to re-create the base64-no-padding encoder over and over. Empirically, saves about 0.5% of all allocations in the http_logs indexing step interestingly enough (according to async profiler).
original-brownbear
added
>non-issue
:Core/Infra/Core
elasticsearchmachine
added
v8.13.0
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
approved these changes
Jan 21, 2024
| @@ -35,6 +35,8 @@ class TimeBasedUUIDGenerator implements UUIDGenerator { | |||
| assert SECURE_MUNGED_ADDRESS.length == 6; | |||
| } | |||
|
|
|||
| private static final Base64.Encoder BASE_64_NO_PADDING = Base64.getUrlEncoder().withoutPadding(); | |||
|
|
|||
| // protected for testing | |||
| protected long currentTimeMillis() { | |||
| return System.currentTimeMillis(); | |||
There was a problem hiding this comment.
Unrelated to your change: is there a reason this generator can't use the cached version of current time from ThreadPool?
There was a problem hiding this comment.
I guess it's a little bothersome code wise, because we use this thing as a static singleton and now it would have a non-static dependency on the threadpool.
Also, and I didn't do the math here, theoretically though probably hard in practice ... if someone sets a very long polling interval on the cache time, that would maybe introduce some chance of collision? Probably not still annoying to adjust this to depend on the pool :)
|
Thanks Ryan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to use a capturing lambda here and also no need to re-create the base64-no-padding encoder over and over.
Empirically, saves about 0.5% of all allocations in the http_logs indexing step interestingly enough (according to async profiler).