Make vectors RefCounted #103645
Merged
Make vectors RefCounted #103645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:QL (Deprecated)
|
Pinging @elastic/es-ql (Team:QL) |
|
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
alex-spies
commented
Dec 21, 2023
| throw new IllegalStateException("can't release already released vector [" + this + "]"); | ||
| } | ||
| released = true; | ||
| blockFactory().adjustBreaker(-ramBytesUsed(), true); |
There was a problem hiding this comment.
The super method already does exactly this.
nik9000
reviewed
Dec 21, 2023
...esql/compute/src/main/java/org/elasticsearch/compute/data/AbstractThreadLocalRefCounted.java
Outdated
Show resolved
Hide resolved
nik9000
approved these changes
Dec 21, 2023
|
Thanks for the quick review @nik9000 ! |
|
Thank you, Alex! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to share vectors among multiple blocks and will be useful for improving the performance of expand and filter operators.
Relates #100528.