Add replay diagnostic dir to system jvm options #103535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When hotspot encounters an error, it will emite a log file which can be used for reproducing the error. This file is dumped to /tmp by default. This commit configures the replay file to be alongside the hs_err file.
rjernst
added
>enhancement
:Core/Infra/CLI
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Hi @rjernst, I've created a changelog YAML for you. |
|
Note to reviewers: I've intentionally not put this configuration in the same place as hs_err in the jvm.options files. This is because every change to that file can cause conflicts to users installing ES with package managers. Instead, I think we should focus on adding new (and maybe moving existing) options to the SystemJvmOptions. |
ChrisHegarty
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hotspot encounters an error, it will emite a log file which can be used for reproducing the error. This file is dumped to /tmp by default. This commit configures the replay file to be alongside the hs_err file.