[ML] Detect timeout when waiting for download task #103197
Merged
+118
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkyle
added
>test
|
Pinging @elastic/ml-core (Team:ML) |
davidkyle
changed the title
# Conflicts: # x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/utils/TaskRetriever.java
|
run elasticsearch-ci/part-4 |
2 similar comments
|
run elasticsearch-ci/part-4 |
|
run elasticsearch-ci/part-4 |
maxhniebergall
approved these changes
Dec 11, 2023
...n/java/org/elasticsearch/xpack/ml/packageloader/action/TransportLoadTrainedModelPackage.java
Show resolved
Hide resolved
droberts195
reviewed
Jan 8, 2024
x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/utils/TaskRetriever.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine update branch |
|
@elasticmachine update branch |
💔 Backport failed
You can use sqren/backport to manually backport by running |
davidkyle
added a commit
to davidkyle/elasticsearch
that referenced
this pull request
Jan 15, 2024
A list tasks timeout indicates the task exists and is in progress. Interpreting the timeout as the task not existing meant the download check would incorrectly assume the download had completed. # Conflicts: # x-pack/plugin/ml-package-loader/src/main/java/org/elasticsearch/xpack/ml/packageloader/action/TransportLoadTrainedModelPackage.java # x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/ml/3rd_party_deployment.yml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 15, 2024
A list tasks timeout indicates the task exists and is in progress. Interpreting the timeout as the task not existing meant the download check would incorrectly assume the download had completed. # Conflicts: # x-pack/plugin/ml-package-loader/src/main/java/org/elasticsearch/xpack/ml/packageloader/action/TransportLoadTrainedModelPackage.java # x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/ml/3rd_party_deployment.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting a model deployment there is a check the a download task is in progress for that model id. This check is called with
wait_for_completion: trueand a timeout of 30 seconds so that the start might wait for the download to finish.The problem is that if the download task is present but does not complete in 30 seconds it would appear there was no task.
ListTasksResponseis aBaseTasksResponse, for these types of responses the node and task exceptions should be checked. When the request times out waiting for a task to complete there are no tasks in the response but there is a node exception with the timeout. The change here is to check for that timeout and return a descriptive error message.The failing test from #103153 is now called with a 1 second timeout as there is no point waiting 30 seconds for the test to fail. The intermittent failures were occurred when the model download did not complete in the default timeout period of 30s so the full model definition was not present.
Closes #103153