Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Connector API] Add docs for create connector API #103177

Merged
merged 14 commits into from
Dec 11, 2023

Conversation

jedrazb
Copy link
Member

@jedrazb jedrazb commented Dec 8, 2023

Adds documentation for the query connector management API. First API documented: create a connector.

@jedrazb jedrazb added >docs General docs changes Team:Docs Meta label for docs team :EnterpriseSearch/Application Enterprise Search Team:Enterprise Search Meta label for Enterprise Search team v8.12.0 v8.13.0 labels Dec 8, 2023
Copy link
Contributor

github-actions bot commented Dec 8, 2023

Documentation preview:

@jedrazb jedrazb marked this pull request as ready for review December 8, 2023 10:37
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ent-search-eng (Team:Enterprise Search)

Copy link
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good. I've left some very minor suggestions.

docs/reference/connector/apis/connector-apis.asciidoc Outdated Show resolved Hide resolved
docs/reference/rest-api/index.asciidoc Outdated Show resolved Hide resolved
[[create-connector-api-response-codes]]
==== {api-response-codes-title}

`200`::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be good to list other response codes too? Just playing around with the API a bit, I came across a 201 and a 500.

Copy link
Member Author

@jedrazb jedrazb Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup added more. Actually the 500 is unexpected - I filed an issue to make a request body a required param (otherwise, without providing the body we can get 500 NullPointerException which is not clear to the user). Will fix it soon

Copy link
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jedrazb jedrazb merged commit 73644bd into elastic:main Dec 11, 2023
6 checks passed
@jedrazb
Copy link
Member Author

jedrazb commented Dec 12, 2023

💚 All backports created successfully

Status Branch Result
8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jedrazb added a commit to jedrazb/elasticsearch that referenced this pull request Dec 12, 2023
elasticsearchmachine pushed a commit that referenced this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :EnterpriseSearch/Application Enterprise Search Team:Docs Meta label for docs team Team:Enterprise Search Meta label for Enterprise Search team v8.12.0 v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants