-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Connector API] Add docs for create connector API #103177
[Connector API] Add docs for create connector API #103177
Conversation
Documentation preview: |
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/ent-search-eng (Team:Enterprise Search) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good. I've left some very minor suggestions.
[[create-connector-api-response-codes]] | ||
==== {api-response-codes-title} | ||
|
||
`200`:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be good to list other response codes too? Just playing around with the API a bit, I came across a 201 and a 500.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup added more. Actually the 500
is unexpected - I filed an issue to make a request body a required param (otherwise, without providing the body we can get 500 NullPointerException which is not clear to the user). Will fix it soon
Co-authored-by: Abdon Pijpelink <[email protected]>
Co-authored-by: Abdon Pijpelink <[email protected]>
Co-authored-by: Abdon Pijpelink <[email protected]>
Co-authored-by: Abdon Pijpelink <[email protected]>
Co-authored-by: Abdon Pijpelink <[email protected]>
Co-authored-by: Abdon Pijpelink <[email protected]>
…drazb/elasticsearch into connector-api-post-request-documented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
(cherry picked from commit 73644bd)
Adds documentation for the query connector management API. First API documented: create a connector.