ESQL: no deep copy in expand #102776
Closed
ESQL: no deep copy in expand #102776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it so the returned block always has to be closed/decRef'd by the caller.
Handle cases without nulls only, for now.
alex-spies
commented
Nov 29, 2023
Comment on lines
+86
to
+89
| if (nullsMask == null) { | ||
| incRef(); | ||
| return new BooleanArrayBlock.Expanded(); | ||
| } |
There was a problem hiding this comment.
This is the main change, the rest is mostly generated or boilerplate.
|
Closing in favor of #103681 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid deep copies when calling
Block::expand, insteadincRef()the current block and return a special, expanded view into the Block.