[ci] Migrate branch consistency and protection checks to Buildkite #101646
Conversation
brianseeders
commented
Oct 31, 2023
•
brianseeders
commented
- Migrate the branch checks to Buildkite
- Go ahead and disable them in Jenkins
- Add a few changes to pipeline templates that were accidentally only added to the generated files
- Fix MAX_WORKERS being 0 on small workers
brianseeders
added
>non-issue
>test-mute
|
Pinging @elastic/es-delivery (Team:Delivery) |
| buildDirectory: /dev/shm/bk | ||
| - label: part3 | ||
| command: .ci/scripts/run-gradle.sh -Dbwc.checkout.align=true -Dorg.elasticsearch.build.cache.push=true -Dignore.tests.seed -Dscan.capture-task-input-files checkPart3 | ||
| timeout_in_minutes: 300 | ||
| agents: | ||
| provider: gcp | ||
| image: family/elasticsearch-ubuntu-2004 | ||
| machineType: custom-32-98304 | ||
| machineType: n1-standard-32 |
There was a problem hiding this comment.
Should we update the machine type on the BWC jobs as well? I just noticed one fail in intake today with a killed test worker.
There was a problem hiding this comment.
I can do that separately, I only changed this one in this branch because it's actually already this machine type, it's just not reflected in the template
| @@ -31,5 +31,10 @@ if ! uname -a | grep -q MING; then | |||
| export GLIBC_VERSION=$(ldd --version | grep '^ldd' | sed 's/.* \([1-9]\.[0-9]*\).*/\1/') | |||
| fi | |||
|
|
|||
| # Running on 2-core machines without ramdisk can make this value be 0 | |||
| if [[ "$MAX_WORKERS" == "0" ]]; then | |||
| MAX_WORKERS=1 | |||
There was a problem hiding this comment.
Should we just make it the number of CPUs then in that case?
There was a problem hiding this comment.
Well, I think it only ends up as 0 if the number of CPUs is 1 or 2... I was thinking that on a 2-CPU machine, there might not really be enough resources to effectively run two tasks in parallel, what do you think?
There was a problem hiding this comment.
We can leave it at one and tweak later.
…lastic#101646) (cherry picked from commit dee880a)
…lastic#101646) (cherry picked from commit dee880a)
…lastic#101646) (cherry picked from commit dee880a) # Conflicts: # .buildkite/pipelines/intake.template.yml
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
