Suppress this-escape warning for JDK21

[benwtrent]

follow up to: #99848

[elasticsearchmachine]

Pinging @elastic/es-delivery (Team:Delivery)

[benwtrent]

@elastic/es-esql Are the files I changed automatically generated? When building with JDK21 with -Werror its angry. So I just added some suppressions, however intellij did a bunch of whitespace changes as well.

[nik9000]

DocVector is fine to change. The lexer and parser are automatically generated. But I don't think you added a warning there.

[benwtrent]

@nik9000 where is the code that generates EsqlBaseLexer & EsqlBaseParser? Those will cause the warnings to trip every time they are regenerated as the generated code doesn't suppress the warnings. I did indeed add suppression to those two classes.

[nik9000]

@nik9000 where is the code that generates EsqlBaseLexer & EsqlBaseParser? Those will cause the warnings to trip every time they are regenerated as the generated code doesn't suppress the warnings. I did indeed add suppression to those two classes.

It's in x-pack/plugin/esql/build.gradle and starts with tasks.register("regen") { er, well, it's actually in antlr, but you can modify the generated files with that gradle code.

[benwtrent]

@nik9000 I added some regex to that regen task. It now adds @SuppressWarnings("this-escape") to every ctor it can find. This seemed easier than trying to figure out the exact ones that had issues, and since its generated, I didn't think that would be an issue.

I re-ran regen locally, and that is what is in the PR now.

[nik9000]

LGTM