Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.11] Fix snapshot double finalization (#101497) #101512

Merged
merged 1 commit into from
Oct 30, 2023
Merged

[8.11] Fix snapshot double finalization (#101497) #101512

merged 1 commit into from
Oct 30, 2023

Conversation

ywangd
Copy link
Member

@ywangd ywangd commented Oct 30, 2023

Backports the following commits to 8.11:

@ywangd
Fix snapshot double finalization (elastic#101497)
86285ad 
When a snapshot is completed as a SnapshotsInProgress entry in cluster
state and also queued for next operations, it can lead to double
finalization of the snapshot if the entry in cluster state is processed
first. This PR fixes it by only start finalization if it is *not*
already in endingSnapshots.

The PR also adds a specific test case for the double finalization issue
(manifested as NPE).

Resolves: elastic#101028
@ywangd ywangd added :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >bug auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. labels Oct 30, 2023
@elasticsearchmachine elasticsearchmachine mentioned this pull request Oct 30, 2023
Merged
@elasticsearchmachine elasticsearchmachine merged commit a3c48f5 into elastic:8.11 Oct 30, 2023
@ywangd ywangd deleted the backport/8.11/pr-101497 branch October 30, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >bug :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.11.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ywangd @elasticsearchmachine