ESQL: Fix loading constant_keyword when unset #101496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a `constant_keyword` field is first created you don't *have* to set it's value - it'll default to `null` and then take on the value of the first document that contains the field. Our block loading code didn't like this state and would fail to run the query. This fixes that.
|
This is labeled |
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
dnhatn
approved these changes
Oct 28, 2023
| - "No limit defined, adding default limit of [500]" | ||
| esql.query: | ||
| body: | ||
| query: 'from test' |
There was a problem hiding this comment.
maybe just add limit N to the query to avoid the warning?
nik9000
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
constant_keywordfield is first created you don't have to set it's value - it'll default tonulland then take on the value of the first document that contains the field. Our block loading code didn't like this state and would fail to run the query. This fixes that.Closes #101455