Make node client type setting a noop #101214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The node client type is a rementant of the transport client. This commit cleans up some test reads and an unnecessary override of the setting. It was already not read anywhere in production. Now it is only registered in order to provide validation. In the future it should be deprecated and removed.
elasticsearchmachine
added
v8.12.0
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
thecoop
approved these changes
Oct 23, 2023
rjernst
added
the
auto-merge-without-approval
floragunncom
pushed a commit
to floragunncom/search-guard
that referenced
this pull request
Mar 3, 2024
floragunncom
pushed a commit
to floragunncom/search-guard
that referenced
this pull request
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node client type is a remnant of the transport client. This commit cleans up some test reads and an unnecessary override of the setting. It was already not read anywhere in production. Now it is only registered in order to provide validation. In the future it should be deprecated and removed.