Fix synonyms documentation #100916
Merged
Fix synonyms documentation #100916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosdelest
added
>docs
carlosdelest
requested review from
benwtrent,
mayya-sharipova and
a team
and removed request for
a team,
benwtrent and
mayya-sharipova
|
Documentation preview: |
|
Pinging @elastic/es-docs (Team:Docs) |
| In the above example, text will be lowercased by the `lowercase` filter before being processed by the `synonyms_filter`. | ||
| This means that all the synonyms defined there needs to be in lowercase, or they won't be found by the synonyms filter. | ||
| {es} will also use the token filters preceding the synonym filter in a tokenizer chain to parse the entries in a synonym file. | ||
| In the above example, the synonyms graph token filter is placed after a stemmer. The stemmer will also be applied to the synonym entries. |
There was a problem hiding this comment.
May be we can say it shorter to avoid repetitions:
Order is important for your token filters.
Text will be processed first through filters preceding the synonym filter before being processed by the synonym filter.
For example, for the above analyzer, {es} will first apply `stemmer` filter to the text, and after that apply `synonym_graph` token filter.
There was a problem hiding this comment.
@mayya-sharipova its important to clarify if we also apply the token filters on the synonyms when they are loaded from the file. This way any stemmer is also applied to the previously stored synonyms.
There was a problem hiding this comment.
I've tried to make the example as close as possible to the previous one to avoid further confusion. I've added synonym set as well to synonym file to ensure users understand that it applies to any synonym configuration.
benwtrent
approved these changes
Oct 17, 2023
💚 Backport successful
|
carlosdelest
added a commit
to carlosdelest/elasticsearch
that referenced
this pull request
Oct 17, 2023
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix documentation related synonym / synonym graph token filters