[buildkite] Upload build artifact and add to build scan #100842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brianseeders
commented
Oct 13, 2023
•
brianseeders
commented
- Upload build artifact to Buildkite.
- Link to the artifacts from the buildscan
- Add a couple of extra buildscan values
brianseeders
added
>non-issue
:Delivery/Tooling
|
Pinging @elastic/es-delivery (Team:Delivery) |
mark-vieira
reviewed
Oct 13, 2023
build-tools-internal/src/main/groovy/elasticsearch.build-complete.gradle
Show resolved
Hide resolved
| @@ -101,7 +101,8 @@ buildScan { | |||
| tag 'CI' | |||
| link 'CI Build', buildKiteUrl | |||
| value 'Job Number', System.getenv('BUILDKITE_BUILD_NUMBER') | |||
|
|
|||
| value 'Pipeline', System.getenv('BUILDKITE_PIPELINE_SLUG') | |||
| value 'Job Name', System.getenv('BUILDKITE_LABEL') | |||
There was a problem hiding this comment.
We should think about sanitizing the label to produce a "slug like" value that's easier to search on. Also stripping out things like emojis (we use them in serverless).
| @@ -101,7 +101,8 @@ buildScan { | |||
| tag 'CI' | |||
| link 'CI Build', buildKiteUrl | |||
| value 'Job Number', System.getenv('BUILDKITE_BUILD_NUMBER') | |||
|
|
|||
| value 'Pipeline', System.getenv('BUILDKITE_PIPELINE_SLUG') | |||
There was a problem hiding this comment.
Can we add these as tags too? We do that for Jenkins.
brianseeders
removed
the
buildkite-opt-in
brianseeders
added a commit
to brianseeders/elasticsearch
that referenced
this pull request
Oct 13, 2023
(cherry picked from commit 17ef0af)
brianseeders
added a commit
to brianseeders/elasticsearch
that referenced
this pull request
Oct 13, 2023
(cherry picked from commit 17ef0af)
brianseeders
added a commit
to brianseeders/elasticsearch
that referenced
this pull request
Oct 13, 2023
(cherry picked from commit 17ef0af) # Conflicts: # build-tools-internal/src/main/groovy/elasticsearch.build-complete.gradle
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
brianseeders
added a commit
that referenced
this pull request
Oct 13, 2023
brianseeders
added a commit
that referenced
this pull request
Oct 13, 2023
brianseeders
added a commit
that referenced
this pull request
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.