Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore version skipping for position fields and synthetic source #100817

Merged
merged 21 commits into from
Oct 13, 2023

Conversation

kkrik-es
Copy link
Contributor

@kkrik-es kkrik-es commented Oct 13, 2023

Follow-up on #100805, overrode a pre-existing skip.

kkrik-es and others added 20 commits October 10, 2023 11:41
# Conflicts:
#	server/src/main/java/org/elasticsearch/index/mapper/SourceFieldMapper.java
#	server/src/test/java/org/elasticsearch/index/mapper/SourceFieldMapperTests.java
#	server/src/test/java/org/elasticsearch/index/query/SearchExecutionContextTests.java
This is an interim step to stop sporadic test failures, while we try to
fix version skip for mixed cluster tests.
# Conflicts:
#	qa/mixed-cluster/build.gradle
@kkrik-es kkrik-es added >test-mute Use for PR that only mute tests Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) auto-backport Automatically create backport pull requests when merged :StorageEngine/TSDB You know, for Metrics v8.11.1 labels Oct 13, 2023
@kkrik-es kkrik-es self-assigned this Oct 13, 2023
@kkrik-es kkrik-es requested a review from martijnvg October 13, 2023 11:15
@kkrik-es kkrik-es marked this pull request as ready for review October 13, 2023 11:15
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kkrik-es kkrik-es merged commit 1f6bffa into elastic:main Oct 13, 2023
@kkrik-es kkrik-es changed the title Restore version skipping for position fields Restore version skipping for position fields and synthetic source Oct 13, 2023
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.11

kkrik-es added a commit to kkrik-es/elasticsearch that referenced this pull request Oct 13, 2023
* Don't print synthetic source in mapping for bwc tests

* Move comment.

* Don't print synthetic source in mapping for bwc tests elastic#2

* Don't print synthetic source in mapping for bwc tests elastic#2

* Revert "Don't print synthetic source in mapping for bwc tests elastic#2"

This reverts commit 034262c.

* Revert "Don't print synthetic source in mapping for bwc tests elastic#2"

This reverts commit 44e8156.

* Revert "Don't print synthetic source in mapping for bwc tests (elastic#100572)"

This reverts commit 9322ab9.

* Exclude synthetic source test from mixedClusterTests

* Update comment.

* Mute all tsdb tests in mixedClusterTests

This is an interim step to stop sporadic test failures, while we try to
fix version skip for mixed cluster tests.

* Remove old exclusion

* Add aggregations too

* Mute tests for versions between 8.7-8.10

* Remove mute

* Restore version skipping for position fields

* Restore version skip for synthetic source
elasticsearchmachine pushed a commit that referenced this pull request Oct 13, 2023
* Don't print synthetic source in mapping for bwc tests

* Move comment.

* Don't print synthetic source in mapping for bwc tests #2

* Don't print synthetic source in mapping for bwc tests #2

* Revert "Don't print synthetic source in mapping for bwc tests #2"

This reverts commit 034262c.

* Revert "Don't print synthetic source in mapping for bwc tests #2"

This reverts commit 44e8156.

* Revert "Don't print synthetic source in mapping for bwc tests (#100572)"

This reverts commit 9322ab9.

* Exclude synthetic source test from mixedClusterTests

* Update comment.

* Mute all tsdb tests in mixedClusterTests

This is an interim step to stop sporadic test failures, while we try to
fix version skip for mixed cluster tests.

* Remove old exclusion

* Add aggregations too

* Mute tests for versions between 8.7-8.10

* Remove mute

* Restore version skipping for position fields

* Restore version skip for synthetic source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :StorageEngine/TSDB You know, for Metrics Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-mute Use for PR that only mute tests v8.11.1 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants