Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] using all privileges #100764

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

juliaElastic
Copy link
Contributor

Follow up after #100684

The issue with the FTR tests hasn't resolved, because I left out delete_index privilege. I decided to use all to make sure nothing else is missing.

  • Have you signed the contributor license agreement? yes
  • Have you followed the contributor guidelines? yes
  • If submitting code, have you built your formula locally prior to submission with gradle check? yes
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. yes
  • If submitting code, have you checked that your submission is for an OS and architecture that we support? yes
  • If you are submitting this code for a class then read our policy for that.

@juliaElastic juliaElastic requested a review from a team as a code owner October 12, 2023 12:29
@juliaElastic juliaElastic self-assigned this Oct 12, 2023
@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team v8.12.0 labels Oct 12, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label Oct 12, 2023
Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; metrics-*-* are part of Fleet's data indexes for which kibana_system should be allowed elevated privileges and this pattern is appropriately listed in the docs as a potential collision pattern.

@juliaElastic juliaElastic merged commit 42cf90f into elastic:main Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Plugins Plugin API and infrastructure external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue Team:Core/Infra Meta label for core/infra team Team:Fleet v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants