Update analysis-common module to use new rest test framework #100719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianseeders
added
:Delivery/Build
|
run elasticsearch-ci/part-1 |
1 similar comment
|
run elasticsearch-ci/part-1 |
brianseeders
added
>non-issue
>test
|
Pinging @elastic/es-delivery (Team:Delivery) |
mark-vieira
approved these changes
Oct 16, 2023
modules/analysis-common/build.gradle
Outdated
| dependencies { | ||
| compileOnly project(':modules:lang-painless:spi') | ||
| clusterModules project(':modules:reindex') | ||
| clusterModules project(':modules:mapper-extras') | ||
| clusterModules project(':modules:analysis-common') |
There was a problem hiding this comment.
It's not necessary to add the current project as a dependency. We do this automatically in the rest testing plugin.
There was a problem hiding this comment.
Ahh, I had to add it in the test class, so I assumed I needed to add it here as well
There was a problem hiding this comment.
Yeah, we should think about eliminating the need for that as well. Perhaps passing in system property to the test that indicates "default" plugins/modules that should be installed.
|
@elasticmachine update branch |
This was referenced Oct 30, 2023
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
brianseeders
added a commit
to brianseeders/elasticsearch
that referenced
this pull request
Oct 30, 2023
brianseeders
added a commit
to brianseeders/elasticsearch
that referenced
this pull request
Oct 30, 2023
brianseeders
added a commit
that referenced
this pull request
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title