-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix interruption of markAllocationIdAsInSync #100610
Merged
DaveCTurner
merged 2 commits into
elastic:main
from
DaveCTurner:2023/10/10/markAllocationIdAsInSync-is-interruptible
Oct 11, 2023
Merged
Fix interruption of markAllocationIdAsInSync #100610
DaveCTurner
merged 2 commits into
elastic:main
from
DaveCTurner:2023/10/10/markAllocationIdAsInSync-is-interruptible
Oct 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`IndexShard#markAllocationIdAsInSync` is interruptible because it may block the thread on a monitor waiting for the local checkpoint to advance, but we lost the ability to interrupt it on a recovery cancellation in elastic#95270. Closes elastic#96578 Closes elastic#100589
DaveCTurner
added
>bug
:Distributed Indexing/Recovery
Anything around constructing a new shard, either from a local or a remote source.
v8.11.1
v8.12.0
labels
Oct 10, 2023
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
label
Oct 10, 2023
Pinging @elastic/es-distributed (Team:Distributed) |
Hi @DaveCTurner, I've created a changelog YAML for you. |
fcofdez
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
DaveCTurner
deleted the
2023/10/10/markAllocationIdAsInSync-is-interruptible
branch
October 11, 2023 08:54
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Oct 11, 2023
`IndexShard#markAllocationIdAsInSync` is interruptible because it may block the thread on a monitor waiting for the local checkpoint to advance, but we lost the ability to interrupt it on a recovery cancellation in elastic#95270. Closes elastic#96578 Closes elastic#100589
💚 Backport successful
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>bug
:Distributed Indexing/Recovery
Anything around constructing a new shard, either from a local or a remote source.
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
v8.11.1
v8.12.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IndexShard#markAllocationIdAsInSync
is interruptible because it mayblock the thread on a monitor waiting for the local checkpoint to
advance, but we lost the ability to interrupt it on a recovery
cancellation in #95270.
Closes #96578
Closes #100589