Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remaining logs tests #100407

Merged
merged 9 commits into from
Oct 11, 2023
Merged

Fix remaining logs tests #100407

merged 9 commits into from
Oct 11, 2023

Conversation

gmarouli
Copy link
Contributor

@gmarouli gmarouli commented Oct 6, 2023

In this PR we convert the remaining 3 yaml logs tests to java rest tests. This should remove all the flaky tests from the data stream yaml suite that's why we are reenabling it.

Closes: #99911
Closes: #97795

@elasticsearchmachine elasticsearchmachine added v8.12.0 needs:triage Requires assignment of a team area label labels Oct 6, 2023
@gmarouli gmarouli added :Data Management/Indices APIs APIs to create and manage indices and templates auto-backport Automatically create backport pull requests when merged v8.11.1 labels Oct 6, 2023
@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team and removed needs:triage Requires assignment of a team area label labels Oct 6, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@gmarouli gmarouli added the >test Issues or PRs that are addressing/adding tests label Oct 10, 2023
@gmarouli
Copy link
Contributor Author

@elasticmachine update branch

@gmarouli gmarouli requested a review from andreidan October 10, 2023 10:21
@gmarouli
Copy link
Contributor Author

@elasticmachine update branch

andreidan
andreidan approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@andreidan andreidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing these tests Mary

@gmarouli gmarouli added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Oct 11, 2023
@elasticsearchmachine elasticsearchmachine merged commit 5dc7ccc into elastic:main Oct 11, 2023
@gmarouli gmarouli deleted the fix-remaining-logs-tests branch October 11, 2023 09:01
@gmarouli gmarouli mentioned this pull request Oct 11, 2023
Merged
gmarouli added a commit to gmarouli/elasticsearch that referenced this pull request Oct 11, 2023
@gmarouli
Fix remaining logs tests (elastic#100407)
37a10ff 
In this PR we convert the remaining 3 yaml logs tests to java rest
tests. This should remove all the flaky tests from the data stream yaml
suite that's why we are reenabling it.

Closes: elastic#99911 Closes:
elastic#97795
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.11

elasticsearchmachine pushed a commit that referenced this pull request Oct 11, 2023
@gmarouli
Fix remaining logs tests (#100407) (#100663)
6117368 
In this PR we convert the remaining 3 yaml logs tests to java rest
tests. This should remove all the flaky tests from the data stream yaml
suite that's why we are reenabling it.

Closes: #99911 Closes:
#97795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreidan andreidan andreidan approved these changes

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Data Management/Indices APIs APIs to create and manage indices and templates Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v8.11.1 v8.12.0
Projects
None yet
Milestone
No milestone
4 participants
@gmarouli @elasticsearchmachine @andreidan @elasticmachine